Discussion:
Doc update for transaction state/status
Scott Carpenter
2018-07-08 20:39:55 UTC
Permalink
I'd proudly make a PR for this if I understood forks. See:

https://github.com/ledger/ledger/blob/next/doc/ledger3.texi#L2913

A transaction can have a ``state'': cleared, pending, or uncleared. The
default is uncleared. To mark a transaction cleared, put an asterisk
@samp{*} before the payee, after the date or code:

I believe this should be:

A transaction can have a ``state'': cleared, pending, or uncleared. The
default is uncleared. To mark a transaction cleared, put an asterisk
@samp{*} after the date, before the code or payee:

In testing, this isn't valid:

2018/07/08 (123) * payee name
--
---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Martin Michlmayr
2018-07-08 21:44:50 UTC
Permalink
Do you want to learn how to or should I just fix it directly?
Yes, good catch.
--
Martin Michlmayr
https://www.cyrius.com/
--
---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Scott Carpenter
2018-07-08 21:50:45 UTC
Permalink
I'd be happy to learn. (I would take pride in having my name in the
contributor list!)
Post by Martin Michlmayr
Do you want to learn how to or should I just fix it directly?
Yes, good catch.
--
Martin Michlmayr
https://www.cyrius.com/
--
---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Scott Carpenter
2018-07-08 21:52:07 UTC
Permalink
I'll accept tips but I should be able to figure this out. :-)
Post by Scott Carpenter
I'd be happy to learn. (I would take pride in having my name in the
contributor list!)
Post by Martin Michlmayr
Do you want to learn how to or should I just fix it directly?
Yes, good catch.
--
Martin Michlmayr
https://www.cyrius.com/
--
---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Martin Michlmayr
2018-07-08 21:53:41 UTC
Permalink
Post by Scott Carpenter
I'd be happy to learn. (I would take pride in having my name in the
contributor list!)
1. Go to https://github.com/ledger/ledger
2. Click "fork" on the upper right corner
3. You'll end up with your own fork at https://github.com/USER/ledger
4. On the command line, check out with
git clone ***@github.com:USER/ledger
5. cd ledger
6. git checkout -b manual
7. edit file
8. git commit -a
9. git push origin
10. GitHub should allow you to do a PR
--
Martin Michlmayr
https://www.cyrius.com/
--
---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Scott Carpenter
2018-07-08 22:00:25 UTC
Permalink
Thank you, Martin. I already have a fork so will learn how to update the
fork. (I previously updated, should be able to do again.) Let me dabble a
bit and will see if I can manage. :-)
Post by Martin Michlmayr
Post by Scott Carpenter
I'd be happy to learn. (I would take pride in having my name in the
contributor list!)
1. Go to https://github.com/ledger/ledger
2. Click "fork" on the upper right corner
3. You'll end up with your own fork at https://github.com/USER/ledger
4. On the command line, check out with
5. cd ledger
6. git checkout -b manual
7. edit file
8. git commit -a
9. git push origin
10. GitHub should allow you to do a PR
--
Martin Michlmayr
https://www.cyrius.com/
--
---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Scott Carpenter
2018-07-08 22:10:46 UTC
Permalink
All right, please let me know if I've failed miserably:

https://github.com/ledger/ledger/pull/1665

Thanks, Martin!
Post by Scott Carpenter
Thank you, Martin. I already have a fork so will learn how to update the
fork. (I previously updated, should be able to do again.) Let me dabble a
bit and will see if I can manage. :-)
Post by Martin Michlmayr
Post by Scott Carpenter
I'd be happy to learn. (I would take pride in having my name in the
contributor list!)
1. Go to https://github.com/ledger/ledger
2. Click "fork" on the upper right corner
3. You'll end up with your own fork at https://github.com/USER/ledger
4. On the command line, check out with
5. cd ledger
6. git checkout -b manual
7. edit file
8. git commit -a
9. git push origin
10. GitHub should allow you to do a PR
--
Martin Michlmayr
https://www.cyrius.com/
--
---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Martin Michlmayr
2018-07-08 22:21:02 UTC
Permalink
The PR includes some merges that shouldn't be there.

And you removed some trailing whitespace, which shouldn't be done or
should be done in a separate patch. But shouldn't be done when
there's a command:

@c Note: The output needs a space character at the end
@c for this test to pass

:)

I'll apply manually with your name on it. Thanks!
--
Martin Michlmayr
https://www.cyrius.com/
--
---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Scott Carpenter
2018-07-09 11:49:07 UTC
Permalink
Argh! Sorry about that and than you, Martin!
Post by Martin Michlmayr
The PR includes some merges that shouldn't be there.
And you removed some trailing whitespace, which shouldn't be done or
should be done in a separate patch. But shouldn't be done when
@c Note: The output needs a space character at the end
@c for this test to pass
:)
I'll apply manually with your name on it. Thanks!
--
Martin Michlmayr
https://www.cyrius.com/
--
---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Scott Carpenter
2018-08-04 20:26:44 UTC
Permalink
Hi, Martin! I hope I've made much less of a mess and hopefully no mess at
all with another PR:

https://github.com/ledger/ledger/pull/1672

Please let me know if any concerns with this one!
Post by Martin Michlmayr
The PR includes some merges that shouldn't be there.
And you removed some trailing whitespace, which shouldn't be done or
should be done in a separate patch. But shouldn't be done when
@c Note: The output needs a space character at the end
@c for this test to pass
:)
I'll apply manually with your name on it. Thanks!
--
Martin Michlmayr
https://www.cyrius.com/
--
---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Loading...